Skip to content

bugfix/refactor: Chat fix#8564

Merged
NightDawnFox merged 2 commits intoss220-space:master220from
littleboobs:chat-fix
Mar 6, 2026
Merged

bugfix/refactor: Chat fix#8564
NightDawnFox merged 2 commits intoss220-space:master220from
littleboobs:chat-fix

Conversation

@littleboobs
Copy link
Collaborator

Что этот ПР делает

Ссылки снова в самом начале любых сообщений. Костыли убраны, нейрослоп насёр тоже. Небольшой рефактор colorize_name, разбил на проки, привёл в подобающий вид.

Демонстрация изменений

Скрины не прикрепляются.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors chat-related code. However, it introduces significant security regressions, specifically Cross-Site Scripting (XSS) vulnerabilities. These arise from the removal of HTML encoding for job titles in AI tracking links and the failure to sanitize speaker names in the refactored colorize_name procedure. Beyond security, there are also recommendations for improving code readability and style guide adherence, such as a style guide violation in code/modules/mob/hear_say.dm concerning conditional operators and a missing comment for a 'magic number' in the normalize_char_code() procedure.

@NightDawnFox NightDawnFox merged commit 9a648fc into ss220-space:master220 Mar 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants